Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search filters to demo timelines #38

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Add search filters to demo timelines #38

merged 14 commits into from
Apr 29, 2024

Conversation

yep-tf2
Copy link
Contributor

@yep-tf2 yep-tf2 commented Jan 19, 2023 •
edited
Loading

Adds:

  • Toggles to hide or show different highlights in the timeline (chat, killfeed, etc)
  • Chat search (only show chat messages matching the input)
  • Player search (only show events relevant to the selected players)

TODO:

  • Fix UI bugs (scroll bars sometimes don't fit the list, and the player search box can show the dropdown without clicking on it)
  • Add more filters (eg point captures, airshots)
  • Improve search filter layout
    • Make search pane expandable to reduce used space (or, maybe shift it to the side of the timeline?) OBE
    • Make toggle switches not take up so much vertical space OBE
  • Code cleanup pass OBE

Video demo

searchable_timeline-2023-01-20_01.44.41.mp4

@rmburg rmburg mentioned this pull request Mar 20, 2023
Closed
@rmburg rmburg added this to the Release 2.0.0 milestone Mar 20, 2023
@rmburg rmburg added the enhancement New feature or request label Mar 27, 2023
@yep-tf2 yep-tf2 marked this pull request as ready for review April 16, 2023 17:21
@yep-tf2 yep-tf2 changed the title [Draft] Add search filters to demo timelines Add search filters to demo timelines Apr 16, 2023
@yep-tf2 @rmburg
First pass at adding search filters to demo timelines
025db64
@yep-tf2 @rmburg
Remove unused vestigal regex code
ddde8e6 
Was intended for use to toggle regexes in chat search, but regex-only search is fine for now
@yep-tf2 @rmburg
Sort player names alphabetically
b84fa27
@yep-tf2 @rmburg
Change filters to toggle buttons from switches
6329805 
Frees up vertical space
Add filtering for airshots and captures
Support filtering captures by player
@rmburg rmburg merged commit 7fb1fb2 into DemomanApp:tauri Apr 29, 2024
2 checks passed
@rmburg
Copy link
Member

rmburg commented Apr 29, 2024

This is a really cool feature, thanks a lot for contributing! And apologies for taking so long to merge it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yep-tf2 @rmburg