JobsReborn Event Improvements #431
Conversation
| @@ -72,6 +76,8 @@ public ObjectTag getContext(String name) { | |||
| case "job" -> job; | |||
| case "experience" -> new ElementTag(event.getExp()); | |||
| case "action" -> new ElementTag(event.getActionInfo().getType().getName(), true); | |||
| case "entity" -> new EntityTag(event.getLivingEntity()); | |||
There was a problem hiding this comment.
The docs say if applicable. but this code always returns an entity - one of the two is wrong
There was a problem hiding this comment.
Yeah my bad. I've added a check for the entity being null 🙂
| @@ -72,6 +76,8 @@ public ObjectTag getContext(String name) { | |||
| case "job" -> job; | |||
| case "experience" -> new ElementTag(event.getExp()); | |||
| case "action" -> new ElementTag(event.getActionInfo().getType().getName(), true); | |||
| case "entity" -> event.getLivingEntity() == null ? null : new EntityTag(event.getLivingEntity()); | |||
There was a problem hiding this comment.
Sorry for the delay, my laptop was out for 3 months so wasn't able to review PRs or anything sadly - assuming this entity could be a player/NPC, need to call #getDenizenObject on that EntityTag (same for the other event)
| // <context.entity> Returns an EntityTag of the entity involved with this event, if applicable. | ||
| // <context.block> Returns a LocationTag of the block involved with this event, if applicable. |
There was a problem hiding this comment.
The meta here looks a little vague - what are the entity/block doing in the context of each event?
There was a problem hiding this comment.
Jobs itself isn't very clear about this.
The entity is the target of the action, so if i killed a pig and earned money/exp, the entity would be the pig i killed.
It's similar for block, where the location is the block i would have modified.
I'm not really sure how else to word it in the meta.
There was a problem hiding this comment.
Acting on feedback from discord, I've added an example and slightly changed the wording on the reviewed lines
Adds <context.entity> and <context.block> to both the Jobs payment and EXP gain events.
Requested by myself: https://discord.com/channels/315163488085475337/1255295264072405032