feat: upcoming payments grid

[abGit9]

This pull request makes the following changes:

Addresses issue #117
Is a follow up to PR #156

Adds feature where upcoming payments can be viewed in a grid. Users can toggle between the default row format and grid format.

[DennisBauer]

Thank you for the PR!

[DennisBauer]

I really like that you extracted the dimensions used in both of the layouts.
Just a few suggestions: Please move the dimension into another file called dimens.xml to separate it from the pure integer values. Also recheck the usage of the dimensions, some of them are not only used for the grid but also the default layout. Therefore I could think of the following naming scheme:

<dimen name="overview_???">...</dimen>
<dimen name="overview_grid_???">...</dimen>
<dimen name="overview_large_???">...</dimen>

But I'm also open for other suggestions.

[abGit9]

yes, will do.

[abGit9]

There is more to be done. I think that we need to style the recurring expense and upcoming payment items. Also, might want to consider persistence options for saving scrolling location of each list/grid. Just a suggestion, but I think it would be good to modularize the pull requests and issues as much as possible. It makes it easier to track different features, bugs, design ideas etc.

[abGit9]

Appreciate the collaboration. Thanks.

[DennisBauer]

There is more to be done. I think that we need to style the recurring expense and upcoming payment items. Also, might want to consider persistence options for saving scrolling location of each list/grid. Just a suggestion, but I think it would be good to modularize the pull requests and issues as much as possible. It makes it easier to track different features, bugs, design ideas etc.

I like your approach. I realized the issue with the scroll position when checking your first PR. Removing the animation resolves this automatically keeping the scroll position for both grid and normal layout, however I haven't looked further into it.

[DennisBauer]

Approve your PR as is, do you want to squash your refactor commit before I merge it?

[abGit9]

I like your approach. I realized the issue with the scroll position when checking your first PR. Removing the animation resolves this automatically keeping the scroll position for both grid and normal layout, however I haven't looked further into it.

Thanks. Yes, you certainly did bring it up! We can work out the issue with scroll position later on. Either keep the animation and find a work around or make a decision to prioritize the scroll position and remove the animations. I am open to both. Let's look into it more and discuss it in the future.

[abGit9]

Approve your PR as is, do you want to squash your refactor commit before I merge it?

I think we can keep the refactor commit if that is ok? There is 1 refactor commit and it applies the modifications(dimens etc) that you suggested. Otherwise, I'm good to go on this PR. I'll continue to work on issues we've mentioned.