Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit memory usage of RocksDB and make it more configurable #1498

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 11, 2024

Description

Limit memory usage of RocksDB and make it more configurable.

Mostly following the guide from Confluent (https://docs.confluent.io/platform/current/streams/developer-guide/memory-mgmt.html). Per default, Kafka Streams creates a RocksDB block cache of up to 50MiB for each state store, which quickly adds up. Since RocksDB memory is off-heap, keeping it contained is a challenge.

With this change, we configure a single block cache to be used for all stores in a Kafka Streams instance. We limit the maximum cache size to 128MiB per default, but provide the ability to configure that if necessary.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Mostly following the guide from Confluent (https://docs.confluent.io/platform/current/streams/developer-guide/memory-mgmt.html). Per default, Kafka Streams creates a RocksDB block cache of up to 50MiB for each state store, which quickly adds up. Since RocksDB memory is off-heap, keeping it contained is a challenge.

With this change, we configure a single block cache to be used for all stores in a Kafka Streams instance. We limit the maximum cache size to 128MiB per default, but provide the ability to configure that if necessary.

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the enhancement New feature or request label Sep 11, 2024
@nscuro nscuro added this to the 0.6.0 milestone Sep 11, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.21% (target: -1.00%) 0.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (232adcc) 172 140 81.40%
Head commit (d8946c3) 6892 (+6720) 5762 (+5622) 83.60% (+2.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1498) 34 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro
Copy link
Member Author

nscuro commented Sep 11, 2024

RocksDbConfigSetter can not be reasonably tested without excessive mocking. Tested manually.

@nscuro nscuro merged commit f363133 into main Sep 11, 2024
12 of 13 checks passed
@nscuro nscuro deleted the rocksdb-memory branch September 11, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant