Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes chunk to be between sent_start and sent_end in BaseTextRank.calc_sent_dist #191

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

clabornd
Copy link
Contributor

@clabornd clabornd commented Aug 6, 2021

As in #77

Copy link
Collaborator

@ceteri ceteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you @clabornd !

@clabornd
Copy link
Contributor Author

clabornd commented Aug 9, 2021

Not sure if this is the issue with the CI failing, but networkx was updated a day after the latest passing build. It appears scipy is not being installed anymore and pip install networkx will not install dependencies, you have to do pip install networkx[default]: https://networkx.org/documentation/stable/install.html

@tomaarsen
Copy link
Contributor

This is indeed related to the CI failing. Each of the tests fail with ModuleNotFoundError: No module named 'scipy'.

@clabornd clabornd requested a review from ceteri August 10, 2021 22:14
@ceteri ceteri merged commit 70778c5 into DerwenAI:main Oct 9, 2021
@ceteri
Copy link
Collaborator

ceteri commented Oct 9, 2021

related #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants