Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biasedrank case fix #217

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Conversation

Ankush-Chander
Copy link
Contributor

@Ankush-Chander Ankush-Chander commented Jun 4, 2022

Description

Biased textrank requires focus from the user to rerank keyphrases as per proximity to the focus tokens.
While adding bias to focus tokens we are matching all tokens(lemma as well as text) against focus tokens(lower case).
To make node bias setting case-independent i am checking lower case token text as well as token lemma with focus tokens.

Types of change

Bug fix

Checklist

  • add test case
  • make focus check case independent
  • add biased textrank documentation in sample notebook

@ceteri
Copy link
Collaborator

ceteri commented Jul 25, 2022

Hi @Ankush-Chander,

Many thanks, these updates look great!
I've just merged #219 and so these tests for this PR should work well.

Although I've been wrangling with the rebase on DerwenAI:main

Would it be possible to re-apply these commits to the current main ?

@ceteri ceteri assigned ceteri and Ankush-Chander and unassigned ceteri Jul 25, 2022
@Ankush-Chander
Copy link
Contributor Author

Hi @ceteri
This branch is now up to date with latest main.
I think we are good to go (except for test case failure with latest spacy3.4.0).

@ceteri
Copy link
Collaborator

ceteri commented Jul 27, 2022

Many thanks @Ankush-Chander !!

(and i'll rework the unit tests now)

@ceteri ceteri merged commit 1f17bc5 into DerwenAI:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants