Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WC-13: Update NEES Sponsors Listing #1475

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Task/WC-13: Update NEES Sponsors Listing #1475

merged 6 commits into from
Nov 13, 2024

Conversation

SilversunKSauri
Copy link
Contributor

Overview:

Update NEES Sponsors listing urls so they work properly

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

If a NEES sponsor url is 'None', it should no longer have a Link that goes to a bad url.

Testing Steps:

  1. example NEES with sponsors that do not link: NEES-2014-1234
  2. example NEES with multiple sponsors that do not link: NEES-2008-0565
  3. example NEES with NSF sponsor links that work: NEES-2011-1082
  4. example NEES with multiple NSF sponsor links that work: NEES-2011-1046
  5. example NEES with one NSF sponsor link and one sponsor with no link: NEES-2010-0905
  6. (testing for no regressions) example NEES with no sponsors listed at all: NEES-2007-0515

UI Photos:

Notes:

Copy link
Contributor

@fnets fnets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally! Needs to a linting fix and a merge from main, but I'm sure you've seen that already. Great job!

@jarosenb jarosenb merged commit 4f2fa08 into main Nov 13, 2024
5 checks passed
@jarosenb jarosenb deleted the task/wc-13 branch November 13, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants