Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/DSAPP-77, task/WA-363: Remote Job Id & Interactive Session Modal handling #1487

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

rstijerina
Copy link
Member

Overview:

  • Displays remote job id (slurm job id) in job detail modals, if it exists
  • Closes interactive session modal if job webhook comes back with failed status

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Go to https://designsafe.dev/rw/workspace/history and confirm Remote Job Id displays for jobs that are past the queuing stage
  2. Submit an interactive job with a runtime of 10 minutes, then confirm the modal closes itself once the job ends

UI Photos:

Screenshot 2024-11-14 at 1 25 43 PM

@rstijerina rstijerina changed the title Task/dsapp 77 wa 363 workspace requests task/DSAPP-77, task/WA-363: Remote Job Id & Interactive Session Modal handling Nov 14, 2024
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

@rstijerina rstijerina merged commit 7faea1b into main Nov 15, 2024
5 checks passed
@rstijerina rstijerina deleted the task/DSAPP-77--WA-363--workspace-requests branch November 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants