fix "Unhandled method" errors caused by lsp requests being sent too e…

…arly or something
DetachHead · Sep 1, 2024 · 2ef4934 · 2ef4934
1 parent eec3a16
commit 2ef4934
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/packages/pyright-internal/src/languageServerBase.ts b/packages/pyright-internal/src/languageServerBase.ts
@@ -579,8 +579,6 @@ export abstract class LanguageServerBase implements LanguageServerInterface, Dis
 
         // Create a service instance for each of the workspace folders.
         this.workspaceFactory.handleInitialize(params);
-        // Bug? Or do we need to send another event always?
-        this.updateSettingsForAllWorkspaces();
 
         if (this.client.hasWatchFileCapability) {
             this.addDynamicFeature(

diff --git a/packages/pyright-internal/src/realLanguageServer.ts b/packages/pyright-internal/src/realLanguageServer.ts
@@ -214,15 +214,10 @@ export abstract class RealLanguageServer extends LanguageServerBase {
             }
         } catch (error) {
             const errorMessage = error instanceof Error ? error.message : error;
-            // workaround for https://github.com/DetachHead/basedpyright/issues/573
-            if (errorMessage === 'Unhandled method workspace/configuration') {
-                this.console.error(`Error reading settings: ${error}`);
-            } else {
-                this.connection.sendNotification(ShowMessageNotification.type, {
-                    message: errorMessage,
-                    type: MessageType.Error,
-                });
-            }
+            this.connection.sendNotification(ShowMessageNotification.type, {
+                message: errorMessage,
+                type: MessageType.Error,
+            });
         }
         return serverSettings;
     }