Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions should not appear on parameter names unless it's a method override #663

Open
DetachHead opened this issue Sep 10, 2024 · 1 comment

Comments

@DetachHead
Copy link
Owner

image

that variable name is completely unrelated. i don't think completions would ever be useful here except when overriding a method

DetachHead added a commit to beauxq/basedpyright that referenced this issue Sep 10, 2024
DetachHead added a commit to beauxq/basedpyright that referenced this issue Sep 10, 2024
DetachHead added a commit to beauxq/basedpyright that referenced this issue Sep 10, 2024
DetachHead added a commit that referenced this issue Sep 10, 2024
@beauxq
Copy link
Contributor

beauxq commented Sep 10, 2024

I think this could have some usefulness, but it could be improved from how it is now.

It can be useful with longer words, so we don't have to type the whole word. But with short examples of 4 or 6 letter words, it's not really useful.


Another way that it could be improved would be to recognize words out of symbol names.
In this example, it would be better if it saw the underscore separating words:
param-complete-underscore-word

So it should only auto-complete hjklcvb, not sndbmnd_hjklcvb.


Like we saw in #655
It's not as useful if it's pulling words from other libraries (or stdlib).
It would be best if it only pulls words from the codebase we're working on.


The auto-complete shouldn't change between lowercase and uppercase, especially when it would violate pep8.
param-complete-case


Some of these adjustments might be easier that others. It might be an overall imrovement to disable them completely if we can't get enough of the individual improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants