Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode: Renaming (any) file in the filetree is very long #826

Closed
FBorowiec opened this issue Oct 29, 2024 · 3 comments · Fixed by #843
Closed

VSCode: Renaming (any) file in the filetree is very long #826

FBorowiec opened this issue Oct 29, 2024 · 3 comments · Fixed by #843
Labels
language server needs investigation awaiting verification by a maintainer that the issue is valid performance pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature

Comments

@FBorowiec
Copy link

Screenshot from 2024-10-29 12-10-14
Hi! First of all, let me tell you what a great tool basedpyright is.
Unfortunately when using VSCode's extension: detachhead.basedpyright when I rename (any) file in VSCode's file tree it takes an incredibly long time.
Is there a setting to prevent the file watcher from looking for all the file types?
Thanks!
@DetachHead DetachHead added language server performance pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature labels Oct 29, 2024
@DetachHead
Copy link
Owner

yeah it takes ages for me on a large codebase as well. the pylance one is pretty much instant. maybe #427 is relevant?

@FBorowiec
Copy link
Author

probably, although the confusing part for me is why does that happen to any file (in my case cpp and starlark files) where no python file is even opened?

@DetachHead DetachHead added the needs investigation awaiting verification by a maintainer that the issue is valid label Oct 30, 2024
@FBorowiec
Copy link
Author

just checked that ms-pyright.pyright doesn't present that issue

FBorowiec added a commit to Stellantis-ADX/vs_code_setup that referenced this issue Oct 30, 2024
@FBorowiec
temp: replaced basedpyright with pyright
b601fd6 
Using ms pyright as long as
DetachHead/basedpyright#826 is active
@DetachHead DetachHead mentioned this issue Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language server needs investigation awaiting verification by a maintainer that the issue is valid performance pylance parity feature that exists in pylance but not pyright / bug specific to our impl of a pylance feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix file rename check running on files that aren't part of the workspace DetachHead/basedpyright
2 participants
@FBorowiec @DetachHead