Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Never type aliases being coloured as a variable when using the new python 3.12 type alias syntax #403

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix Never type aliases being coloured as a variable when using the new python 3.12 type alias syntax #403

merged 1 commit into from
Jun 11, 2024

Conversation

DetachHead
Copy link
Owner

fixes #402

@DetachHead DetachHead requested a review from KotlinIsland June 10, 2024 10:35
@DetachHead DetachHead force-pushed the never-type-alias-moment branch 3 times, most recently from ec69125 to 780be7d Compare June 10, 2024 10:52
@DetachHead DetachHead force-pushed the never-type-alias-moment branch from 780be7d to f72e3a0 Compare June 10, 2024 10:56
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@DetachHead DetachHead merged commit 8ef0d41 into main Jun 11, 2024
11 checks passed
@DetachHead DetachHead deleted the never-type-alias-moment branch June 11, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KotlinIsland KotlinIsland KotlinIsland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python 3.12 type aliases to Never are coloured as a value instead of a type
2 participants
@DetachHead @KotlinIsland