Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lsp-bridge in installation.md #479

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Conversation

manateelazycat
Copy link
Contributor

No description provided.

docs/installation.md Outdated Show resolved Hide resolved
@DetachHead
Copy link
Owner

DetachHead commented Jul 7, 2024

thanks! i also went ahead and removed thsoe other links, because as far as i can tell they won't work with basedpyright.

@DetachHead DetachHead merged commit 8762727 into DetachHead:main Jul 7, 2024
5 checks passed
@Schnouki
Copy link

i also went ahead and removed thsoe other links, because as far as i can tell they won't work with basedpyright.

They do! I've been using basedpyright with Emacs and eglot for a few months now. Just needed to add the following to my Emacs config:

(add-to-list 'eglot-server-programs
             '((python-mode python-ts-mode)
               "basedpyright-langserver" "--stdio"))

Pretty sure that a similar config is also possible with lsp-mode.

Eglot is built-in in recent Emacs versions, and lsp-mode is the more mature and popular option for LSP support in Emacs. I'd recommend keeping them in the docs too.

@DetachHead
Copy link
Owner

@Schnouki thanks for the info, i've added them back in #493, do you mind taking a look and letting me know if there's anything i got wrong?

@Schnouki
Copy link

@DetachHead Looks alright to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants