Updated third-party and libs deps + improved package_win_release.bat and build_win_premake.bat + added generate_credits.bat from SOURCE.txt files. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I #10 and then this . Thanks all of you! |
otavepto
reviewed
Aug 18, 2024
| if %BUILD_DEPS% equ 1 ( | ||
| set "CMAKE_GENERATOR=Visual Studio 17 2022" | ||
| call "%PREMAKE_EXE%" --file="premake5-deps.lua" --64-build --32-build --all-ext --all-build --j=2 --verbose --clean --os=windows vs2022 | ||
| if %errorlevel% neq 0 ( |
There was a problem hiding this comment.
since this line is inside a block/brackets, errorlevel will be expanded before even the previous line is executed (expansion before execution, or entire block expansion).
you can use !errorlevel! instead to defer the evaluation until this line is about to be executed.
another option is the short-circuit operator:
call myapp.exe || goto :bad_code
This was referenced Aug 18, 2024
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/build/win)
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/common/linux)
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/common/win)
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/deps/common)
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/deps/linux)
Detanup01
added a commit
that referenced
this pull request
Aug 19, 2024
Fix #12 (third-party/deps/win)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.