forked from nexgen999/gbe_fork
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for some crashes + behavior enhancements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vs countof) * change steam paths in HKCU
* fix invalid overlapping of data in steam_remote_storage due to invalid usage of union
…p if the function arg was null
* fix a potential problem in `Steam_User::GetUserDataFolder()` where an incomplete path might be copied
* remove duplicate callback triggered in `Steam_Friends::SetPersonaName()`
… are requested by games * delete ended game_stats sessions after 15 seconds to reduce memory usage
…neGameMode()` * mimic real behavior in `Steam_Timeline::AddTimelineEvent()`
…rver_list_actual_type` in configs.main.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steam_gamestats
steam_remote_storage
steam_remote_storage
due to invalid usage of unionSteam_User::GetUserDataFolder()
where an incomplete path might be copiedmatchmaking_server_list_actual_type
in configs.main.inisteam_http
if the function arg was nullgame_stats
for servers, client and server instances are requested by games, turns out this is a client/server shared interfacesteam_remote_storage
steam_ugc
steam_utils
steam_user
steam_friends
Steam_Friends::SetPersonaName()
steam_networking_socketserialized
RegQueryValueExW()
andRegSetValueExW()
(sizeof
vscountof
), these functions take the buffer size in bytes, not the count of elements:https://learn.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regsetvalueexw
https://learn.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regqueryvalueexw
mode=2
HKCU
to point at the loader, and clean them up on exitSourceModInstallPath
to point at the folder of the loader, this impacts Source engine based games, cleaned up on exitgame_stats
sessions after15 seconds
to reduce memory usageSteam_Timeline::SetTimelineGameMode()
to mimic real behavior