Implement Steam_User_Stats::GetAchievementIcon()
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 18, 2024 04:59
* don't add new image resource if current one exists
…lder when loading overlay icons
* load all achievements icons in memory when loading the achievements schema
…he icon filepath to load the icon resource
…equested, rather than loading them on the next call to the run callback * move stats options in the ini to a separate section [main::stats]
…s, instead wait for the next call to the run callback * fix a bug where loaded image handle wasn't being saved
…age and exit, when the ovrlay is ready it will display it
… icon was shown instead of the gray/locked one * don't save/cache the achievement icon handle to allow lazy loading * make the test achievement load either locked or unlocked icon randomly * don't attempt to load the icon more than once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steam_User_Stats::GetAchievementIcon()ISteamUserStatsrather than in the overlay, this is done in the periodic callback which is run on a separate threadlazy_load_achievements_iconsinconfigs.main.iniwhich is enabled by default, to lazy load achievements icons in memory when they're requested, rather than loading them on the next call to the periodic callback of theISteamUserStatsinterfaceconfigs.main.inito a new separate section[main::stats]lazy_load_achievements_iconsoptionISteamUserStatsrather than manually loading the image from diskachievement_imagesfolder when loading icons, makes programming easier + it is no longer valid since the user stats interface is taking care of icons loading nowreadyflag in networking callback, save the chat message and exit, whenthe overlay is ready it will display it on next frame render, this avoids a scenario where a chat message might be missed if the overlay took too long to initialize
generate_emu_configtool contains name and descriptionVulkanheaderssteam_user_statsclass into multiple files for readabilitySome games like appid 2242420 (free game) need this API, otherwise the launcher will crash.
The lazy loading option is enabled by default because some games like appid 218620 (payday 2) have a huge number of achievements, loading the icons all at once in the constructor would take ~2 mins.
When this option is disabled, the background thread will trigger the periodic callback which will then load the icons, that way the constructor won't be affected.