-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show github annotation on specific errors. #106
Show github annotation on specific errors. #106
Conversation
Heck let me add the conflict too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I do wonder if we could put these in some other place so that we don't forget if we ever add more (maybe it could be part of the should_suggest_issue
function in error.rs
...?)
@cole-h I was looking around for a good way to do this but didn't immediately think of one. Now that I've tested this works I may actually have an idea... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
Show a Github Actions error annotation on UNAUTHORIZED responses such that users may see experience an elevated error experience in this expected error case.