Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show github annotation on specific errors. #106

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Feb 9, 2024

Show a Github Actions error annotation on UNAUTHORIZED responses such that users may see experience an elevated error experience in this expected error case.

@Hoverbear Hoverbear marked this pull request as ready for review February 9, 2024 18:19
@Hoverbear Hoverbear requested a review from cole-h February 9, 2024 18:19
@Hoverbear Hoverbear self-assigned this Feb 9, 2024
@Hoverbear
Copy link
Contributor Author

Heck let me add the conflict too

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do wonder if we could put these in some other place so that we don't forget if we ever add more (maybe it could be part of the should_suggest_issue function in error.rs...?)

@Hoverbear
Copy link
Contributor Author

@cole-h I was looking around for a good way to do this but didn't immediately think of one. Now that I've tested this works I may actually have an idea...

@Hoverbear Hoverbear requested a review from cole-h February 9, 2024 20:25
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@Hoverbear Hoverbear merged commit 6e81dc4 into main Feb 12, 2024
5 checks passed
@Hoverbear Hoverbear deleted the hoverbear/fh-196-block-new-user-and-organization-creation-on-flakehub-push branch February 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants