Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple --github-token and is_github_actions logic #112

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

Hoverbear
Copy link
Contributor

Furthers #109 to decouple the --github-token and is_github_actions logic. This should make it quite easy to add support for running in other contexts once FlakeHub itself supports those.

@Hoverbear Hoverbear self-assigned this Feb 21, 2024
@Hoverbear Hoverbear changed the title Decouple --github-token and is_github_actions logic Decouple --github-token and is_github_actions logic Feb 21, 2024
@Hoverbear Hoverbear marked this pull request as ready for review February 22, 2024 16:27
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected!

@cole-h cole-h merged commit d079d46 into main Feb 23, 2024
9 checks passed
@cole-h cole-h deleted the decouple-github-token-and-github-actions branch February 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants