Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for case-insensitive README names #70

Merged
merged 12 commits into from
Aug 30, 2023
Merged

Allow for case-insensitive README names #70

merged 12 commits into from
Aug 30, 2023

Conversation

lucperkins
Copy link
Member

The Option/Result logic I use to suss this out is pretty gnarly. I'm open to suggestion on how to clean it up.

@lucperkins lucperkins requested a review from cole-h August 25, 2023 01:06
lheckemann
lheckemann reviewed Aug 25, 2023
View reviewed changes
src/release_metadata.rs Outdated Show resolved Hide resolved
@lucperkins @lheckemann
Make read_dir expression less complex
4021ed4 
Co-authored-by: Linus Heckemann <git@sphalerite.org>
grahamc
grahamc reviewed Aug 25, 2023
View reviewed changes
src/release_metadata.rs Outdated Show resolved Hide resolved
lucperkins and others added 2 commits August 29, 2023 16:06
@lucperkins
Copy link
Member Author

lucperkins commented Aug 29, 2023 •
edited
Loading

@lheckemann So, it turns out that this isn't so straightforward, as tokio::fs::ReadDir has a different API than std::fs::ReadDir. My solution here is a bit verbose and I'm open to suggestion on less-verbose alternatives.

lheckemann
lheckemann reviewed Aug 29, 2023
View reviewed changes
src/release_metadata.rs Outdated Show resolved Hide resolved
lucperkins and others added 2 commits August 29, 2023 19:15
@lucperkins @lheckemann
Opt for early return
661b6d1 
Co-authored-by: Linus Heckemann <git@sphalerite.org>
@lucperkins
Return file string rather than string
bc9b55b
@grahamc grahamc merged commit e974b13 into main Aug 30, 2023
5 checks passed
@grahamc grahamc deleted the lucperkins/ds-1194-make-readme-detection-case-insensitive branch August 30, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@cole-h cole-h Awaiting requested review from cole-h

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucperkins @grahamc @lheckemann