Read README from flake's store path #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were reading the README from the current working directory because of a couple things: * We were reading `entry.file_name()` instead of `entry.path()`, which would be something like `README.md`, instead of a full path to the file. This would lead to reading the `README.md` (if it existed) from the current directory rather than the directory we just searched through. * We were using the `flake_root` (the root of the git repository) to find the README. This would mean that we would read the `README.md` from wherever this git root was, rather than from the flake itself. Now, we read it from the flake's store path.
Hoverbear
approved these changes
Sep 18, 2023
|
This may have an issue related to https://github.com/DeterminateSystems/flakehub/blob/8a6efa3113dfde88b7d617d648de380c91186b72/src/route/upload.rs#L741-L758 ... |
cole-h
deleted the
cole/ds-1077-readmemd-is-read-from-passed-directory-not-from-nix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were reading the README from the current working directory because of a couple things:
We were reading
entry.file_name()instead ofentry.path(), which would be something likeREADME.md, instead of a full path to the file. This would lead to reading theREADME.md(if it existed) from the current directory rather than the directory we just searched through.We were using the
flake_root(the root of the git repository) to find the README. This would mean that we would read theREADME.mdfrom wherever this git root was, rather than from the flake itself. Now, we read it from the flake's store path.