Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launchdupd #1088

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Launchdupd #1088

merged 5 commits into from
Aug 15, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 15, 2024

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc changed the base branch from main to dnixd-test August 15, 2024 15:57
cole-h
cole-h approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits / questions aside, LGTM.

@grahamc grahamc marked this pull request as ready for review August 15, 2024 16:53
@grahamc grahamc merged commit 5774e2b into dnixd-test Aug 15, 2024
21 checks passed
@grahamc grahamc deleted the launchdupd branch August 15, 2024 16:53
cole-h added a commit that referenced this pull request Aug 15, 2024
@grahamc @cole-h
Test --determinate in CI, and fix integration issues (#1084)
c0cd969 
* Run ci with --determinate too

* fixup ConfigureInitService: handle cases where systemd dosen't have a src

* Remove the nixd service file in revert

* missed one

* breakpoint

* update determinate

* ?

* help

* V

* ?

* ?

* bump

* flake.lock: Update

Flake lock file updates:

• Updated input 'determinate/determinate-nixd-aarch64-darwin':
    'https://install.determinate.systems/determinate-nixd/rev/86c4b11d7253132a88cd9a549976f4d20df0bf2b/macOS?narHash=sha256-1w9JUBWVWQCk%2BBK7PX9e7Tsyj1Yk4mEqavJ14H%2BDSXQ%3D'
  → 'https://install.determinate.systems/determinate-nixd/rev/948f25bd2d5742ee96ec938d9ae7709e4458420c/macOS?narHash=sha256-l7O%2BD9w8YBYIceeAMalRl8htBQqHlzTdDpel8RHMjLg%3D'
• Updated input 'determinate/determinate-nixd-aarch64-linux':
    'https://install.determinate.systems/determinate-nixd/rev/86c4b11d7253132a88cd9a549976f4d20df0bf2b/aarch64-linux?narHash=sha256-HnCWt6YSrCSH/UCDy2gZTVVOAB3IdqRocL5N8f%2B5bDM%3D'
  → 'https://install.determinate.systems/determinate-nixd/rev/948f25bd2d5742ee96ec938d9ae7709e4458420c/aarch64-linux?narHash=sha256-pe75u0gwtwBTo2i2lsNU636EARrU93hLVndRXrcdYBA%3D'
• Updated input 'determinate/determinate-nixd-x86_64-linux':
    'https://install.determinate.systems/determinate-nixd/rev/86c4b11d7253132a88cd9a549976f4d20df0bf2b/x86_64-linux?narHash=sha256-TtPPHtY54INYXxKSbbATsjuo5x0TLxv25K1GPCz044w%3D'
  → 'https://install.determinate.systems/determinate-nixd/rev/948f25bd2d5742ee96ec938d9ae7709e4458420c/x86_64-linux?narHash=sha256-jdVMi3vpL8xweNWW5w1ku2tGPS60P/qDfp825beXroo%3D'

* Wait for bootout to complete

* Brekapoint

* Correct boolean inversion on unmounted disks

* Fixup is_mounted check

* Make the init configurator support arbitrary socket files (#1086)

* drop breakpoint

* Correct the sleep in the daemon-down test

* Note what the for loop is for

* revert inherit cmd

* Launchdupd (#1088)

* Fixup socket activation to use other paths

* Create a CreateDeterminateVolumeService for mounting

* oops: actually run the steps

* Fixup nits

* re-lock dnidx

* flake.lock: Update determinate, remove determinate-nixd input overrides

Flake lock file updates:

• Updated input 'determinate':
    'https://api.flakehub.com/f/pinned/DeterminateSystems/determinate/0.1.66%2Brev-fba019bd147f9b294210824514a4632737289af2/019132bb-fce1-769d-b5b2-9c2da35fd178/source.tar.gz?narHash=sha256-csYhSmOLgECu8/rLxMFsUN4Oj6upqn9kCYjPv7wft8s%3D' (2024-08-08)
  → 'https://api.flakehub.com/f/pinned/DeterminateSystems/determinate/0.1.79%2Brev-d4641809cba36cb41a0546d2ef9a6f73e96f7528/01915744-ae45-7ab9-a7e4-66db2d5f8263/source.tar.gz?narHash=sha256-G%2BOX5pHEBRbQVNBV1mpWiSQtyeq2FphneLI6UvGfRjw%3D' (2024-08-15)

---------

Co-authored-by: Cole Helbling <cole.helbling@determinate.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@colemickens colemickens colemickens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamc @colemickens @cole-h