-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix 2.13.3 -> 2.15.0 #428
Nix 2.13.3 -> 2.15.0 #428
Conversation
The path that we care about here needs to be updated here, yeah? nix-installer/src/action/common/configure_shell_profile.rs Lines 151 to 160 in 8bb37f1
|
Thanks @abathur NixOS/nix@2384d36 |
Instead of writing out the /nix/var/nix.... path, we need to update to match this commit: NixOS/nix@2384d36 ...which implies we need to capture the XDG_STATE_HOME value from the parent before we sudo and pass it through. If XDG_STATE_HOME isn't set, default to $HOME/.local/state -- again captured before we sudo. |
We might be able to skip all this extra complexity and hard-code it, but I'm wondering if that would break users of the action on self-hosted runners. |
Doing a full VM/container test pass on this. |
Passes! ⭐ |
Description
Closes #286.
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: