Add Pingback feature #38
Conversation
lib/pingback.js
Outdated
| 'result': data.result, | ||
| 'action': data.action, | ||
| 'url': data.url, | ||
| 'source': 'algolia-crawler' |
app.js
Outdated
| console.log(data.message); | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
I do not think we need to output anything here. Simply append to the errors array
lib/pingback.js
Outdated
|
|
||
| res.setEncoding('utf8'); | ||
|
|
||
| console.log(res.statusCode); |
lib/pingback.js
Outdated
| res.setEncoding('utf8'); | ||
|
|
||
| console.log(res.statusCode); | ||
| process.exit(); |
lib/pingback.js
Outdated
| console.log(res.statusCode); | ||
| process.exit(); | ||
|
|
||
| if (res.statusCode === 404) { |
There was a problem hiding this comment.
We do not need to handle 404 differently that if it is non-200
app.js
Outdated
| if (pingback.ok == false) { | ||
| console.log('No ping back url configured or bad url.'); | ||
| console.log(pingback.error); | ||
| console.log(); |
There was a problem hiding this comment.
I do not thing we need this error, since no pingback is ok.
|
Should we include a unit test too ? |
README.md
Outdated
| result=[success|error] | ||
| action=[update|delete] | ||
| url=the url inserted | ||
| source=”algolia-crawler” |
app.js
Outdated
|
|
||
| //Add empty line | ||
| console.log(); | ||
|
|
There was a problem hiding this comment.
We can remove that empty line
There was a problem hiding this comment.
Quote removed from readme.md
app.js
Outdated
| result: 'success', | ||
| action: 'delete', | ||
| url: url.url | ||
| }, tearDown); |
There was a problem hiding this comment.
Why not pass the callback in the data object ?
There was a problem hiding this comment.
And why wait for the pingback to complete ?
There was a problem hiding this comment.
To keep console log in sync.
lib/pingback.js
Outdated
| err: err | ||
| }); | ||
| }; | ||
| req.on('error', (e) => callback(e)); |
There was a problem hiding this comment.
There are too many functions here. Either pass callback directly to error, or inline it. I think that the inline is the best.
|
@fhamon Pretty hard to unit test a http request... |
|
@nitriques This could be usefull ? https://github.com/nock/nock |
|
@fhamon yes it would! but mocking is a little bit like voodoo. |
No description provided.