Fix DeepPartial type #22789
Merged
Fix DeepPartial type #22789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaKhD
force-pushed
the
khd/fix-deep-partial
branch
from
ca64582 to
9c85872
Compare
IlyaKhD
force-pushed
the
khd/fix-deep-partial
branch
from
81eed7a to
075870f
Compare
pomahtri
previously approved these changes
Sep 30, 2022
This was referenced Sep 30, 2022
Merged
Merged
pomahtri
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks
Practical Value
This fixes
DeepPartialtype which recursively wraps all object fields. Recursion becomes infinite and causesTS2589: Type instantiation is excessively deep and possibly infiniteerror.Before
DeepPartialrecursion does not stop on scalar types (string,number, etc.): considering them as object typesAfter
Recursion terminated at non-object types.
Links