-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: updated the "globby" dependency (v11.0.4) #6321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating fast-glob from v2 to v3 was introduced a bug (mrmlnc/fast-glob#290) which prevents to return results for the globs containing trailing slashes.
However, I think we should preserve current behaviour for our users, because for now this is a breaking change for us. For example:
If pass the e2etests/**/*/
pattern, TestCafe should run all of the tests placed in the e2etests
dir and subdirs. So, we should delete trailing slashes not only for (['test/', 'tests/'])
, but for the globs specified by users too.
Purpose
Approach
There are two issues to resolve after updating to
globby@11
:1. No result for the directory trailing forward slash (
['test/', 'tests/']
). Deleted the slashes in these changes. Added theGLOB_POSIX_SLASH_ENDING
workaroundReproducible example.
Init:
index.js
2. Used POSIX in glob templates (
ensurePosix
). See references.index.js
References
https://github.com/sindresorhus/globby#api:
mrmlnc/fast-glob#290
Pre-Merge TODO