Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 Première version de la lib #5

Merged
merged 83 commits into from
Feb 21, 2021
Merged

🔀 Première version de la lib #5

merged 83 commits into from
Feb 21, 2021

Conversation

MathieuSoysal
Copy link
Member

@MathieuSoysal MathieuSoysal commented Feb 21, 2021 •
edited
Loading

Cette branche contient l'implémentation :

@MathieuSoysal
🎉 First Commit
e109176
@MathieuSoysal
🔨 Ajout TypeDepartement
7f06741
@MathieuSoysal
🔨 Ajout Region
2479cc0
@MathieuSoysal
🔨 Ajout Departement DPT
f978c22
@MathieuSoysal
🛑 Ajout test non-validé RegionTest
64aabf1
@MathieuSoysal
🔨 Validation test Region
7eac4fe
@MathieuSoysal
✏ Correction typos Departement
ccef533
@MathieuSoysal
🔨 Ajout des noms : Region.java
9065d45
@MathieuSoysal
🔨 Ajout des départements de DOM, TOM et PTOM
25c9056
@MathieuSoysal
🛑 Ajout test non-validé Departement
181d4e9
@MathieuSoysal
🛑 Ajout test non-validé OutilGeneraux
6d0739c
@MathieuSoysal
🔨 Validation OutilsGeneraux
ecbb905
@MathieuSoysal
⚡ LazyLoad Region
63f5c52
@MathieuSoysal
🔨 Validation de tous les tests
c4dd696
@MathieuSoysal
🛑 Ajout test non-validé Departement
ab490fa
@MathieuSoysal
🛑 Ajout test non-validé OutilsDepartement
f18d6bc
@MathieuSoysal
🛑 Ajout test non-validé OutilsString
53e5bb8
@MathieuSoysal
🛑 Ajout test non-validé OutilsString : indexOfDifference
d3836d7
@MathieuSoysal
🔨 Validation des tests OutilsString
b7a5ed1
@MathieuSoysal
🔨 Validation de tous les tests
7ab2fe6
@MathieuSoysal
✅ Ajout tests de protection (coverage)
fca8c1f
@MathieuSoysal
♻ Refactorisation Outils
014051d
@MathieuSoysal
♻ Refactorisation OutilsDepartement
3d371c7
@MathieuSoysal
🛑 Ajout test non-validé Region
2add5cf
@MathieuSoysal
🛑 Ajout test non-validé OutilsRegion
7a97a58
@MathieuSoysal
✅🛑 Correction test non-validé
932d9af
@MathieuSoysal
🔨 Validation OutilsRegion
78b773d
@MathieuSoysal
🔨 Validation de tous les tests
f92096a
@MathieuSoysal
♻ Refactorisation OutilsDepartement
1b108b8
@MathieuSoysal
♻ Refactorisation
f801570
@MathieuSoysal MathieuSoysal added the enhancement New feature or request label Feb 21, 2021
@MathieuSoysal MathieuSoysal self-assigned this Feb 21, 2021
BioTheWolff
BioTheWolff approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@BioTheWolff BioTheWolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Caumune changed to Commune.
All tests passing; I believe in what was coded and won't look through the code in details.

@BioTheWolff BioTheWolff self-assigned this Feb 21, 2021
This was linked to issues Feb 21, 2021
✨ Implémenter les départements #1
Closed
✨ implémenter les villes de France #2
Closed
✨ Implémenter les régions de France #3
Closed
💚 Ajouter les CI #4
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2021 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.5% 83.5% Coverage
0.0% 0.0% Duplication

pierreantoine-cheron
pierreantoine-cheron approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@pierreantoine-cheron pierreantoine-cheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whaouh c stylé

@MathieuSoysal MathieuSoysal merged commit acae988 into main Feb 21, 2021
@MathieuSoysal MathieuSoysal deleted the initial-depot branch February 21, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BioTheWolff BioTheWolff BioTheWolff approved these changes

@pierreantoine-cheron pierreantoine-cheron pierreantoine-cheron approved these changes

@emerick-biron emerick-biron Awaiting requested review from emerick-biron

Assignees

@MathieuSoysal MathieuSoysal

@BioTheWolff BioTheWolff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@MathieuSoysal @BioTheWolff @pierreantoine-cheron