Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac embeddings #1116

Merged
merged 21 commits into from
Apr 10, 2024
Merged

Fix mac embeddings #1116

merged 21 commits into from
Apr 10, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Apr 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

DevToys, when built in Release, won't run unless the Git repository is cloned on the local machine. This is due to the fact that the staticassetweb file is pointing to the physical path of the git repository, which obviously, is wrong as our customers won't have it on their machine.

What is the new behavior?

I tried making this file changing at build, I tried not including this file, but none of this worked.
So as an alternative, I embedded every sources in DevToys.Blazor and made a IFileProvider that gets these resources.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler marked this pull request as ready for review April 10, 2024 02:49
@veler veler merged commit 3c97ea4 into main Apr 10, 2024
3 checks passed
@veler veler deleted the fix-mac-embeddings branch April 10, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant