Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Commit

Permalink
ccxt api change also need since parameter to be 'undefined' for binan…
Browse files Browse the repository at this point in the history
…ce (#1268)

Also the since argument must be type of undefined see: https://github.com/ccxt/ccxt/blob/master/js/binance.js#L747
  • Loading branch information
Haehnchen authored and DeviaVir committed Feb 2, 2018
1 parent 348d776 commit f928065
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extensions/exchanges/binance/exchange.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ module.exports = function container (get, set, clear) {
}

var client = publicClient()
client.fetchTrades(joinProduct(opts.product_id), '',undefined, args).then(result => {
client.fetchTrades(joinProduct(opts.product_id), undefined, undefined, args).then(result => {
var trades = result.map(function (trade) {
return {
trade_id: trade.id,
Expand Down

1 comment on commit f928065

@Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented on f928065 Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh funny, i told this here #1256, but yeah i was told its not needed... but good work!

Please sign in to comment.