This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
MACD trigger sell signal for overbought instead of just notify #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found no reasen in MACD (for at least) why not trigger a sell signal for overbought_rsi indicator. as this indicator triggers only one signal per trend. moreover i am also wondering why all strategies that implement this also only notify an upcoming event. so do i miss something here? whenever there is a simulation running into rsi with this changes iam getting higher profit from it.
DeviaVir
approved these changes
Feb 5, 2018
This was referenced Mar 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found no reasen in MACD (for at least) why not trigger a sell signal for overbought_rsi indicator. as this indicator triggers only one signal per trend. moreover i am also wondering why all strategies that implement this also only notify an upcoming event. so do i miss something here. A 'sold' signal is catche nowhere?
whenever there is a simulation running into rsi with this changes iam getting higher profit from it.
Please review this change extensively, because of behavior change