This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix bug with preroll when 0 volume #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix getCursor on Kraken exchange, getCursor must return milliseconds to be consisitent with API calls to getTrades in backfill and trade commands. It was returning seconds, this would cause entries to be returned outside of their respective time periods. Also removed opts.to and replace with opts.from. opts.to is only used for 'backward' history scans, not forward. This was always effectively undefined in this case.
DeviaVir
approved these changes
Aug 11, 2017
DeviaVir
pushed a commit
that referenced
this pull request
Aug 14, 2017
* Really re-order on "post only" error Check for balance error also on checkOrder (e.g. bitfinex, using websockets, reports the error later than other exchanges) * Initial commit to switch bitfinex to websockets * Select pair on first getTrade() * Fixed bitfinex buy and sell from commandline * Bitfinex: Trigger calc of wallet balances on getBalance over websockets and retun updated balances * Bitfinex: Removed duplicate definition of symbol * Bitfinex: Now using only one websockets connection * Bitfinex WS: Better error handling on connect/auth/sending messages * Bitfinex WS: Further improving retries and error handling * Bitfinex WS: Not directly calling the websockets part of the bitfinex module for close() anymore * Fix bug with preroll when 0 volume (#464) * Fix bug with preroll when 0 volume Fix getCursor on Kraken exchange, getCursor must return milliseconds to be consisitent with API calls to getTrades in backfill and trade commands. It was returning seconds, this would cause entries to be returned outside of their respective time periods. Also removed opts.to and replace with opts.from. opts.to is only used for 'backward' history scans, not forward. This was always effectively undefined in this case. * Formatting kraken exchange.js * Bitfinex WS: Fixed wallet recalc when asset or currency are 0 * Really re-order on "post only" error Check for balance error also on checkOrder (e.g. bitfinex, using websockets, reports the error later than other exchanges) * Initial commit to switch bitfinex to websockets * Select pair on first getTrade() * Fixed bitfinex buy and sell from commandline * Bitfinex: Trigger calc of wallet balances on getBalance over websockets and retun updated balances * Bitfinex: Removed duplicate definition of symbol * Bitfinex: Now using only one websockets connection * Bitfinex WS: Better error handling on connect/auth/sending messages * Bitfinex WS: Further improving retries and error handling * Bitfinex WS: Not directly calling the websockets part of the bitfinex module for close() anymore * Bitfinex WS: Fixed wallet recalc when asset or currency are 0 * Bitfinex WS: New reconnect approach, honor "INSUFFICIENT MARGIN" * Bitfinex WS: Missing ) * Bitfinex WS: Remove debug logging on "close"
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Fix bug with preroll when 0 volume Fix getCursor on Kraken exchange, getCursor must return milliseconds to be consisitent with API calls to getTrades in backfill and trade commands. It was returning seconds, this would cause entries to be returned outside of their respective time periods. Also removed opts.to and replace with opts.from. opts.to is only used for 'backward' history scans, not forward. This was always effectively undefined in this case. * Formatting kraken exchange.js
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
…r#458) * Really re-order on "post only" error Check for balance error also on checkOrder (e.g. bitfinex, using websockets, reports the error later than other exchanges) * Initial commit to switch bitfinex to websockets * Select pair on first getTrade() * Fixed bitfinex buy and sell from commandline * Bitfinex: Trigger calc of wallet balances on getBalance over websockets and retun updated balances * Bitfinex: Removed duplicate definition of symbol * Bitfinex: Now using only one websockets connection * Bitfinex WS: Better error handling on connect/auth/sending messages * Bitfinex WS: Further improving retries and error handling * Bitfinex WS: Not directly calling the websockets part of the bitfinex module for close() anymore * Fix bug with preroll when 0 volume (DeviaVir#464) * Fix bug with preroll when 0 volume Fix getCursor on Kraken exchange, getCursor must return milliseconds to be consisitent with API calls to getTrades in backfill and trade commands. It was returning seconds, this would cause entries to be returned outside of their respective time periods. Also removed opts.to and replace with opts.from. opts.to is only used for 'backward' history scans, not forward. This was always effectively undefined in this case. * Formatting kraken exchange.js * Bitfinex WS: Fixed wallet recalc when asset or currency are 0 * Really re-order on "post only" error Check for balance error also on checkOrder (e.g. bitfinex, using websockets, reports the error later than other exchanges) * Initial commit to switch bitfinex to websockets * Select pair on first getTrade() * Fixed bitfinex buy and sell from commandline * Bitfinex: Trigger calc of wallet balances on getBalance over websockets and retun updated balances * Bitfinex: Removed duplicate definition of symbol * Bitfinex: Now using only one websockets connection * Bitfinex WS: Better error handling on connect/auth/sending messages * Bitfinex WS: Further improving retries and error handling * Bitfinex WS: Not directly calling the websockets part of the bitfinex module for close() anymore * Bitfinex WS: Fixed wallet recalc when asset or currency are 0 * Bitfinex WS: New reconnect approach, honor "INSUFFICIENT MARGIN" * Bitfinex WS: Missing ) * Bitfinex WS: Remove debug logging on "close"
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix getCursor on Kraken exchange, getCursor must return milliseconds to be consisitent with API calls to getTrades in backfill and trade commands. It was returning seconds, this would cause entries to be returned outside of their respective time periods.
Also removed opts.to and replace with opts.from. opts.to is only used for 'backward' history scans, not forward. This was always effectively undefined in this case.