This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Genetic algorithm to fine tune strategy parameters #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crubb
suggested changes
Oct 7, 2017
emabo
reviewed
Oct 7, 2017
scripts/genetic_algo/parsing.py
Outdated
|
|
||
| def args_for_strategy(strat): | ||
| available = subprocess.check_output(shlex.split('/app/zenbot.sh list-strategies')) | ||
| strats = [strat.strip() for strat in available.split(b'\n\n')] |
There was a problem hiding this comment.
import re
ansi_escape = re.compile(b'\x1b[^m]*m')
available = subprocess.check_output(shlex.split('/app/zenbot.sh list-strategies'))
strats = [ansi_escape.sub(b'', strat.strip()) for strat in available.split(b'\n\n')]
Could I propose these lines to get rid of ANSI escape sequences? otherwise it seems to me that this function is not able to parse correctly command options. NB: I'm using python scripts outside docker container.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #299 has stalled for quite a while now, I grabbed the code and put it in the
scripts/dir, so it'll be easier for other devs to keep working on it. In its current state, the code has unfortunately decayed quite a bit.Please review: