Add .aab installation support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koral--
requested changes
Sep 20, 2020
lib/util/bundletool.js
Outdated
| module.exports = function(options) { | ||
| return new Promise(function(resolve, reject) { | ||
| var defaultBaseDir = ('/tmp/bundletool') | ||
| var bundletoolUrl = 'https://api.github.com/repos/google/bundletool/releases/latest' |
There was a problem hiding this comment.
IMO bundletool should be bundled with docker image.
STF may be deployed in various environments which may not have network access.
koral--
approved these changes
Sep 28, 2020
|
Of course, I'll update this branch on latest changes |
Signed-off-by: nghia.viminh <nghia.viminh@gameloft.com>
Signed-off-by: nghia.viminh <nghia.viminh@gameloft.com>
…dletool binary in storage-temp Signed-off-by: nghia.viminh <nghia.viminh@gameloft.com>
Signed-off-by: nghia.viminh <nghia.viminh@gameloft.com>
nghiaviminh
force-pushed
the
gameloft/aab-installation
branch
from
e57b982
to
ee3e00c
Compare
|
I've rebased the branch, you can merge the changes. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag & drop installation and launching of .aab files. Set your own keystore options to sign APKs in storage-temp unit