Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ffi): remove Pkcs12Mac iterations from FFI interface #319

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(ffi): remove Pkcs12Mac iterations from FFI interface #319

merged 1 commit into from
Oct 30, 2024

Conversation

thenextman
Copy link
Member

The Iterations getter on Pkcs12MacAlgorithm doesn't build in dotnet:

error CS0266: Cannot implicitly convert type 'uint*' to 'uint?'. An explicit conversion exists (are you missing a cast?)

I'm unsure right now how to fix this in diplomat, but the field seems to just be for completeness / an implementation detail. So for now, I remove it from the FFI interface.

@thenextman thenextman enabled auto-merge (squash) October 30, 2024 13:55
CBenoit
CBenoit approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thenextman thenextman merged commit 7d0f9e0 into master Oct 30, 2024
11 checks passed
@thenextman thenextman deleted the remove-mac-iterations-from-ffi branch October 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

@pacmancoder pacmancoder Awaiting requested review from pacmancoder

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thenextman @CBenoit @pacmancoder