fix: build failure for scard feature

src/generator.rs

@@ -198,7 +198,8 @@ where
         Generator::new(move |_| async move { value })
     }
 }
-/// Utilitiies for working with network client
+
+/// Utilities for working with network client
 impl<'a, OutTy> Generator<'a, NetworkRequest, crate::Result<Vec<u8>>, OutTy>
 where
     OutTy: 'a + Send,

src/kerberos/mod.rs

@@ -432,10 +432,9 @@ impl Sspi for Kerberos {
         }
         #[cfg(feature = "scard")]
         if let Some(CredentialsBuffers::SmartCard(ref identity_buffers)) = self.auth_identity {
-            return Ok(ContextNames {
-                username: utf16_bytes_to_utf8_string(&identity_buffers.username),
-                domain: None,
-            });
+            let username = utf16_bytes_to_utf8_string(&identity_buffers.username);
+            let username = crate::Username::parse(&username).map_err(|e| Error::new(ErrorKind::InvalidParameter, e))?;
+            return Ok(ContextNames { username });
         }
         Err(crate::Error::new(
             crate::ErrorKind::NoCredentials,

src/negotiate.rs

@@ -518,12 +518,12 @@ impl<'a> Negotiate {
                     .ok_or_else(|| Error::new(ErrorKind::NoAuthenticatingAuthority, "can not detect KDC url"))?;
                 info!("Negotiate: try Kerberos");
 
-                self.protocol =
-                    NegotiatedProtocol::Kerberos(Kerberos::new_client_from_config(crate::KerberosConfig {
-                        url: Some(host),
-                        network_client: self.network_client_factory.network_client(),
-                        hostname: Some(self.hostname.clone()),
-                    })?);
+                let config = crate::KerberosConfig {
+                    kdc_url: Some(host),
+                    client_computer_name: Some(self.client_computer_name.clone()),
+                };
+
+                self.protocol = NegotiatedProtocol::Kerberos(Kerberos::new_client_from_config(config)?);
             }
         }
 

src/pk_init.rs

@@ -60,7 +60,7 @@ pub struct Wrapper<T> {
     pub content: ExplicitContextTag0<T>,
 }
 
-pub type SignDataFn = Box<dyn Fn(&[u8]) -> Result<Vec<u8>>>;
+pub type SignDataFn = Box<dyn Fn(&[u8]) -> Result<Vec<u8>> + Send>;
 
 pub struct GenerateAsPaDataOptions<'a> {
     pub p2p_cert: Certificate,