-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerberos smart card credentials handling #143
Merged
CBenoit
merged 86 commits into
kerberos-smart-card-dev
from
kerberos-smart-card-credentials
Aug 25, 2023
Merged
Changes from 2 commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
bae70b9
feat(sspi): add scard feature;
TheBestTvarynka f59c379
fix(ntlm): warnings
TheBestTvarynka ff9b339
feat(ffi): add scrd feature
TheBestTvarynka 2159b19
feat(kerberos): implement certificate extraction by thumbprint
TheBestTvarynka 752de6c
feat(sspi): builders: implement the transform method for accept secur…
TheBestTvarynka 49cbaa0
feat(sspi): builders: implement the transform method for acquire cred…
TheBestTvarynka 5819366
feat(sspi): builders: implement the transform method for init sec con…
TheBestTvarynka 0f64ac4
feat(auth_identity): add and implement Credetials/CredentialsBuffers
TheBestTvarynka ad4c612
feat(sspi): negotiate: improved credentials passing: now we can pass …
TheBestTvarynka 99b5767
feat(sspi): kerberos: improved credentials passing: now we can pass r…
TheBestTvarynka bbe8c67
fix(sspi): builders: accept_sec_context: change lifetime too in full_…
TheBestTvarynka 3291998
fix(sspi): builder: acq_cred_handle: change lifetime too in full_tran…
TheBestTvarynka 01f59ec
fix(sspi): builder: init_sec_context: change lifetime too in full_tra…
TheBestTvarynka 28ceadd
fix(sspi): negotiate: mutation and references errors
TheBestTvarynka ba8d7fa
feat(sspi): credssp: improved credentials passing: now we can pass re…
TheBestTvarynka 9c71619
feat(sspi): sspi_cred_ssp: improved credentials passing: now we can p…
TheBestTvarynka c913293
feat(ffi): add support of the Credentials/CredentialsBuffers instead …
TheBestTvarynka b78f390
feat(sspi): auth_identity: add username field to smart card creds;
TheBestTvarynka 075ed41
feat(ffi): handle smart card creds in tsssp;
TheBestTvarynka e9b12c0
feat(ffi): small refactoring
TheBestTvarynka 5f76d84
feat(ffi): format code;
TheBestTvarynka 53c5e78
feat(cargo.toml): temporary replaces picky-* crates with local ones;
TheBestTvarynka 845832e
feat(credssp): ts_request: improve credentials encoding/decoding: use…
TheBestTvarynka 3591304
feat(credssp): ts_request: tests: improved tests according to the cre…
TheBestTvarynka 195fdaa
feat(sspi): refactor cert_utils and smart card credentials;
TheBestTvarynka 351d746
feat(credssp): improved credentials encryption/decryption;
TheBestTvarynka ab36b1e
feat(sspi): credssp: format code. improve credentials encoding: remov…
TheBestTvarynka 2699233
feat(sspi): auth_identity: add card_name, container_name, and csp_nam…
TheBestTvarynka 999c400
fix(ffi): auth_identity: compilation error in smart card credentials;
TheBestTvarynka eaadcb5
feat(sspi): cert_utils: implement smart card info (key container name…
TheBestTvarynka 9407775
feat(sspi): cert_utils: implememt user name extraction from the smart…
TheBestTvarynka 12f50af
feat(ffi): auth_identity: improve credentials gathering;
TheBestTvarynka 88c1062
feat(ffi): format code;
TheBestTvarynka 29cf34b
feat(sspi): cert_utils: format code;
TheBestTvarynka 6a3240c
feat(sspi): cert_utils: improve logging;
TheBestTvarynka ff77833
fix(sspi): cert_utils: smart card info finalizing;
TheBestTvarynka ab18461
fix(sspi): credssp: ts_request: smart card credentials encoding;
TheBestTvarynka 9fd02e7
feat(ffi): auth_identity: improve smart card creds handling;
TheBestTvarynka 4f46ddd
feat(sspi): auth_identity: add private_key_file_index field;
TheBestTvarynka bf56850
feat(sspi): cert_utils: implement private_key_file_index calculation;
TheBestTvarynka 464641f
feat(ffi): auth_identity: improve smart card creds handling;
TheBestTvarynka a0d7131
feat(sspi): auth_identity: smart card: make scard name optional;
TheBestTvarynka bb9f5d0
feat(sspi): credssp: improve smart card creds writing;
TheBestTvarynka 055f2e6
feat(ffi): auth_identity: improve smart card credentials handlings;
TheBestTvarynka df7d1f0
feat(ffi): fix clippy warnings;
TheBestTvarynka fdbc5fc
feat(sspi): negotiate: fix clippy warnings;
TheBestTvarynka 0880fc0
feat(sspi): builders: fix clippy warnings;
TheBestTvarynka 6de545b
fix(sspi): cert_utils: private_key_index calculation;
TheBestTvarynka 032e1c6
fix(ffi): auth_identity: smart card creds handling: add null byte to …
TheBestTvarynka d7d949a
feat(sspi): return error from SspiEx::custom_set_auth_identity method;
TheBestTvarynka 622e6d4
feat(sspi): utils: improve string_to_utf16 function;
TheBestTvarynka 75edea3
feat(sspi): auth_identity: add more doc commets. improve conversion;
TheBestTvarynka c345505
feat(sspi): credssp: small refactoring;
TheBestTvarynka 0707394
fix(sspi): pku2u: return Result from custom_set_auth_identity function;
TheBestTvarynka dd3f9c9
fix(sspi): kerberos: return Result from custom_set_auth_identity func…
TheBestTvarynka 0614542
feat(sspi): negotiate: small refactoring;
TheBestTvarynka 8f02d9c
feat(sspi): builders: small refactoring. add more comments;
TheBestTvarynka 1171daa
feat(sspi): ntlm: small refactoring;
TheBestTvarynka 30ccb2d
feat(sspi): credssp: small refactoring. improve conditional compilation;
TheBestTvarynka 3b086f4
feat(sspi): cert_utils: code and tests refactoring. add more comments…
TheBestTvarynka df69f56
feat(ffi): sec_handle: refactor acquire credentials handle;
TheBestTvarynka 9bd7bd3
feat(ffi): utils: remove uneeded function str_to_utf16_bytes;
TheBestTvarynka ab38e33
feat(ffi): auth_identity: small refactoring;
TheBestTvarynka 5b42210
feat(sspi): Cargo.toml: remove default features;
TheBestTvarynka 793af2e
sspi: refactoring;
TheBestTvarynka 2159a7e
feat(sspi): cert_utils: improved upn extraction from certificate;
TheBestTvarynka 3e5ce34
feat(sspi): format code;
TheBestTvarynka 12e0645
feat(ffi): remove default features. improve conditional compilation;
TheBestTvarynka 4c90b88
feat(sspi): cert_utils: improve conditional compilation;
TheBestTvarynka 4652e80
feat(ffi): auth_identity: improve conditional compilation;
TheBestTvarynka 33aab3e
feat(sspi): update picky-* dependencies: replace local paths with git…
TheBestTvarynka bcb1c3c
feat(sspi): small refactoring;
TheBestTvarynka d2d25cb
feat(ffi): format code;
TheBestTvarynka 671a000
revert rust toolchain version: 1.71.0 -> 1.71.1;
TheBestTvarynka d20660d
feat(sspi): add support of smart card credentials in the credssp clie…
TheBestTvarynka 75845a4
sspi: update picky-* dependencies
TheBestTvarynka b89ff48
fix: wasm-testcompile compilation
TheBestTvarynka 9e3eb9d
feat(ffi): add comment about SEC_WINNT_AUTH_IDENTITY_UNICODE flag
TheBestTvarynka ba71154
feat(ffi): revert and improve auth_data_to_identity_buffers function
TheBestTvarynka eafbbda
fix(ffi): replace auth_data_to_identity_buffers_q/w with auth_data_to…
TheBestTvarynka 9046202
feat(ffi): add comment about auth_data_to_identity_buffers function
TheBestTvarynka 0455a71
fix(sspi): cert_utils module conditional compilation
TheBestTvarynka 49e70c0
sspi: update picky-* dependencies
TheBestTvarynka 55d2f9c
feat(ffi): improve smart card credentials detection
TheBestTvarynka 0de5681
Merge branch 'kerberos-smart-card-credentials' of ssh://jira.dev.loca…
TheBestTvarynka ade277b
feat(ffi): improve smart card credentials handling. format code
TheBestTvarynka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling CredIsMarshaledCredentialW should be enough, it checks for @@ under the hood anyway. maybe the only potential issue is that CredIsMarshaledCredentialW could return true for types other than 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed