Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARC-144] Replace Network Client with Generator Enumerator #176

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[ARC-144] Replace Network Client with Generator Enumerator #176

merged 1 commit into from
Sep 26, 2023

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Sep 25, 2023 •
edited
Loading

Add Generator Based IO structure

Motivation

Allow SSPI-rs to be completly IO-free, yield the IO operation back to the caller using generator. Hence can be used in the browser.

@irvingoujAtDevolution irvingoujAtDevolution added the documentation Improvements or additions to documentation label Sep 25, 2023
CBenoit
CBenoit reviewed Sep 25, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
src/negotiate.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit reviewed Sep 25, 2023
View reviewed changes
src/kerberos/mod.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit reviewed Sep 25, 2023
View reviewed changes
src/credssp/mod.rs Show resolved Hide resolved
src/generator.rs Outdated Show resolved Hide resolved
src/generator.rs Show resolved Hide resolved
src/negotiate.rs Outdated Show resolved Hide resolved
src/ntlm/test.rs Outdated Show resolved Hide resolved
src/pku2u/mod.rs Outdated Show resolved Hide resolved
src/credssp/mod.rs Outdated Show resolved Hide resolved
src/credssp/mod.rs Outdated Show resolved Hide resolved
@CBenoit CBenoit self-assigned this Sep 25, 2023
@CBenoit CBenoit marked this pull request as draft September 25, 2023 20:16
@CBenoit CBenoit removed the documentation Improvements or additions to documentation label Sep 25, 2023
CBenoit
CBenoit reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irvingoujAtDevolution you need to fix the errors reported by CI

@irvingoujAtDevolution
Copy link
Contributor Author

@irvingoujAtDevolution you need to fix the errors reported by CI

Will do, and I have error with ffi as well, I'll fix ffi and push it for review

CBenoit
CBenoit reviewed Sep 26, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
CBenoit
CBenoit reviewed Sep 26, 2023
View reviewed changes
src/generator.rs Outdated Show resolved Hide resolved
src/generator.rs Outdated Show resolved Hide resolved
CBenoit
CBenoit reviewed Sep 26, 2023
View reviewed changes
src/generator.rs Outdated Show resolved Hide resolved
@irvingoujAtDevolution irvingoujAtDevolution marked this pull request as ready for review September 26, 2023 20:16
CBenoit
CBenoit approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@irvingoujAtDevolution irvingoujAtDevolution merged commit 949d360 into master Sep 26, 2023
40 checks passed
@irvingoujAtDevolution irvingoujAtDevolution deleted the irving/add-generator-attempt-1 branch September 26, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees

@CBenoit CBenoit

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @CBenoit