[ARC-144] add if condition for HTTP target, allow winrm connection #178

irvingoujAtDevolution · 2023-10-06T18:10:23Z

winrm connection seems disagree with Ker5 user to user protocol, add a new if condition, if the target is http (aka winrm server), then use plain kerbero5 protocol instead of user to user

feat: add if condition for HTTP target

src/kerberos/mod.rs

.github/workflows/ci.yml

CBenoit

Thank you!

Cargo.toml

examples/kerberos.rs

CBenoit · 2023-10-06T21:00:52Z

examples/kerberos.rs

+
+fn main() -> Result<(), Box<dyn Error + Send + Sync>> {
+    tracing_subscriber::fmt()
+        .with_max_level(tracing::Level::DEBUG) // Adjust level as needed


Use EnvFilter

Marking as unresolved as you do not appear to be using EnvFilter yet

examples/kerberos.rs

CBenoit · 2023-10-06T21:46:08Z

Cargo.toml

-rustls = { version = "0.21", features = ["dangerous_configuration"], optional = true }
+rustls = { version = "0.21", features = [
+  "dangerous_configuration",
+], optional = true }


Please, do you think you could configure your editor to not automatically re-format all Cargo.toml you touch? It would be preferable so we don’t end up with noise, and don’t deviate too much from other Rust projects.

Most Rust projects typically does not use this formatting. This is well explained by the style guide from the Rust compiler: "[f]or array values, such as a list of features, put the entire list on the same line as the key, if it fits".

I would prefer we wait for official support in rustfmt before we apply such automatic formatting.

updated, both the my disabled my vscode formatter and the file. Do you have a recommanded toml formatter tool for this?

Sadly there is currently no blessed formatter for Cargo.toml as of today (but that would be rust-lang/rustfmt#5240 when it’s ready)

CBenoit · 2023-10-06T21:55:58Z

src/kerberos/mod.rs

@@ -889,7 +1075,7 @@ impl<'a> Kerberos {
                let encoded_auth = picky_asn1_der::to_vec(&authenticator)?;
                info!(encoded_ap_req_authenticator = ?encoded_auth);

-                // FIXME: properly negotiate mech id - Windows always does KRB5 U2U
+                // FIXME: properly negotiate mech id - Windows always does KRB5 U2U for Non-HTTP Target


Is it an issue we should track seriously, and create an issue for it?
cc @awakecoding

CBenoit · 2023-10-06T23:36:38Z

src/kerberos/mod.rs

+            // 4 = size of u32
+            nonce: &OsRng.gen::<[u8; 4]>(),


Note that you could use core::mem::size_of::<u32>() so the code is self-explanatory

this is direct copy from original code

Oh okay, I understand. Do you think you could address this anyway while you’re at it? Thank you

Note: another alternative is

OsRng.gen::<u32>().to_ne_bytes(),

src/kerberos/mod.rs

Co-authored-by: Benoît Cortier <bcortier@proton.me>

…' of https://github.com/Devolutions/sspi-rs into ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM

CBenoit · 2023-10-07T18:11:31Z

examples/kerberos.rs

-        username,
-        password: password.into(),
-        domain: None,
+#[cfg(feature = "network_client")]


You can put this at the top of the file:

#![cfg(feature = "network_client")]

the problem is that cargo test needs to see the main function present in the file. if I put it on top, it will not pass cargo test

You’re right! Actually, in this case you should remove the#[cfg]s altogether, and add this at the bottom of the Cargo.toml instead:

[[example]] name = "kerberos" required-features = ["network_client"]

This specifies that this example needs the "network_client" feature enabled in order to be compiled and it will be ignored if the feature is not available.

irvingoujAtDevolution · 2023-10-10T13:52:58Z

I will keep this PR as draft, just in case I found things not working with my winrm client

irvingoujAtDevolution · 2023-10-18T13:44:13Z

Not correct path, problem solved without using the newly implemented variation of Kerb5 protocol

irvingoujAtDevolution requested a review from CBenoit October 6, 2023 18:10

feat: add if condition for HTTP target

bef493f

feat: add if condition for HTTP target

irvingoujAtDevolution force-pushed the ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM branch from 1fd8f76 to bef493f Compare October 6, 2023 18:14

irvingoujAtDevolution requested a review from RRRadicalEdward October 6, 2023 18:15

awakecoding reviewed Oct 6, 2023

View reviewed changes

src/kerberos/mod.rs Outdated Show resolved Hide resolved

irvingoujAtDevolution added 2 commits October 6, 2023 14:36

fix typo

21c5092

do not test examples

bfbd797

irvingoujAtDevolution commented Oct 6, 2023

View reviewed changes

src/kerberos/mod.rs Outdated Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

CBenoit reviewed Oct 6, 2023

View reviewed changes

irvingoujAtDevolution and others added 9 commits October 7, 2023 12:09

Update src/kerberos/mod.rs

f9a79c4

Co-authored-by: Benoît Cortier <bcortier@proton.me>

Update examples/kerberos.rs

b2b5574

Co-authored-by: Benoît Cortier <bcortier@proton.me>

Update examples/kerberos.rs

fb2a5c1

Co-authored-by: Benoît Cortier <bcortier@proton.me>

Update examples/kerberos.rs

ac8805b

Co-authored-by: Benoît Cortier <bcortier@proton.me>

Update src/kerberos/mod.rs

8d9fab6

Co-authored-by: Benoît Cortier <bcortier@proton.me>

fix review issues

334dfec

Merge branch 'ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM…

57de199

…' of https://github.com/Devolutions/sspi-rs into ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM

cargo better format

6515f19

update cargo

d17813d

irvingoujAtDevolution requested review from CBenoit and awakecoding October 7, 2023 17:42

CBenoit reviewed Oct 7, 2023

View reviewed changes

a few more fix and experiments

75b4542

irvingoujAtDevolution closed this Oct 18, 2023

irvingoujAtDevolution deleted the ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM branch October 18, 2023 13:46

CBenoit mentioned this pull request Oct 18, 2023

fix: small fix for generator related changes and variable naming #180

Merged

irvingoujAtDevolution restored the ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM branch October 27, 2023 18:25

CBenoit deleted the ARC-144-sspi-rs-WASM-module-and-JavaScript-API-for-NTLM branch March 7, 2024 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARC-144] add if condition for HTTP target, allow winrm connection #178

[ARC-144] add if condition for HTTP target, allow winrm connection #178

irvingoujAtDevolution commented Oct 6, 2023

CBenoit left a comment

CBenoit Oct 6, 2023

irvingoujAtDevolution Oct 7, 2023

CBenoit Oct 10, 2023

CBenoit Oct 6, 2023 •

edited

Loading

irvingoujAtDevolution Oct 7, 2023

CBenoit Oct 10, 2023

CBenoit Oct 6, 2023

CBenoit Oct 6, 2023

irvingoujAtDevolution Oct 7, 2023

CBenoit Oct 7, 2023 •

edited

Loading

CBenoit Oct 7, 2023 •

edited

Loading

irvingoujAtDevolution Oct 10, 2023

CBenoit Oct 10, 2023

irvingoujAtDevolution commented Oct 10, 2023

irvingoujAtDevolution commented Oct 18, 2023

[ARC-144] add if condition for HTTP target, allow winrm connection #178

[ARC-144] add if condition for HTTP target, allow winrm connection #178

Conversation

irvingoujAtDevolution commented Oct 6, 2023

CBenoit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CBenoit Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CBenoit Oct 7, 2023 • edited Loading

Choose a reason for hiding this comment

CBenoit Oct 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irvingoujAtDevolution commented Oct 10, 2023

irvingoujAtDevolution commented Oct 18, 2023

CBenoit Oct 6, 2023 •

edited

Loading

CBenoit Oct 7, 2023 •

edited

Loading

CBenoit Oct 7, 2023 •

edited

Loading