refactor: clarify naming of user-facing options #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
force-pushed
the
clarify-naming
branch
2 times, most recently
from
be59d7f
to
d1c685f
Compare
awakecoding
approved these changes
Nov 8, 2023
CBenoit
force-pushed
the
clarify-naming
branch
3 times, most recently
from
8097534
to
7a28e36
Compare
CBenoit
force-pushed
the
clarify-naming
branch
from
7a28e36
to
412f9e5
Compare
- When appropriate, "hostname" was renamed into "client_computer_name" - Likewise, "Kerberos::url" has been renamed to "Kerberos::kdc_url" and the meaning of the field has been documented (KDC url vs KKDCP url) - A wrapper around username is exposed to the library user to make it clear that there are different formats: - User Principal Name (UPN) - Down-Level Logon Name Convenience functions are provided to help the user building proper usernames.
CBenoit
force-pushed
the
clarify-naming
branch
from
412f9e5
to
1a2138e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appropriate, "hostname" was renamed into "client_computer_name"
Likewise, "Kerberos::url" has been renamed to "Kerberos::kdc_url" and the meaning of the field has been documented (KDC url vs KKDCP url)
A wrapper around username is exposed to the library user to make it clear that there are different formats:
Convenience functions are provided to help the user building
proper usernames.