-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ffi): include the scard feature by default #302
Conversation
2e7bce7
to
5efbf47
Compare
@TheBestTvarynka Does enabling scard by default for the ffi crate sounds good to you, or should it stay an option? Also, the CI is hitting more compilation issues such as:
|
Hm, got it. Let me fix it |
b4bed06
to
64993ef
Compare
@TheBestTvarynka I rebased on top of master |
64993ef
to
88a4b95
Compare
f105d3a
to
2af75c3
Compare
@TheBestTvarynka Looks like there are still a few compilation errors. Can you fix the problems directly on my branch? |
Yes, give a few minutes |
Finally, the CI is happy |
cc @TheBestTvarynka