ci: fix sspi-ffi test job for Windows #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, we rename symbols using a .def file. For that, we emit a cargo instruction. > cargo:rustc-link-arg=/DEF:sspi.def However, when attempting to run unit tests this causes an error. ``` Caused by: could not execute process `<redacted>` (never executed) Caused by: %1 is not a valid Win32 application. (os error 193) ```
awakecoding
approved these changes
Jan 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, we rename symbols using a .def file.
For that, we emit a cargo instruction.
However, when attempting to run unit tests this causes an error.
There is currently no built-in way to check if cargo is going to run the tests from the build.rs itself:
rust-lang/cargo#4001
This commit adds a new environment variable that when set prevent the instruction emission.