Fix label <> type for user attribute #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Jason, I noticed your interest in this provider and I think you will be more interested in this new looker provider. https://github.com/devoteamgcloud/terraform-provider-looker |
ajbosco
approved these changes
Nov 7, 2022
jsnb-devoted
pushed a commit
that referenced
this pull request
Nov 9, 2022
* change group membership interface and fix acc test * add how to run acc test on README * update doc * fix ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest plan wants to create all the user attributes that already exist. I'm not actually sure if terraform can identify that these resources already exist if they haven't been imported into the terraform state. I was mucking around and noticed this. I thought maybe we might be constructing the id wrong and that is why it thinks it needs to create all these -- that is probably not the case.
Also there seems to be a pretty active fork off of this repo:
https://github.com/hirosassa/terraform-provider-looker
Maybe we pull their commits into ours? Our use theirs?