Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor image quality #93

Closed
Dinosane2 opened this issue Jun 14, 2020 · 1 comment
Closed

Poor image quality #93

Dinosane2 opened this issue Jun 14, 2020 · 1 comment

Comments

@Dinosane2
Copy link

Even without set .compress() or setting .compress(0) the image resulting looks like it WAS indeed compressed.

Digging I found out that this happens due to CompressionProvider.kt:172 which compress 10% of any jpg without had been instruct to !

There are any reason to this?

    // Check file format
    var format = Bitmap.CompressFormat.JPEG
    var quality = 90
    if (file.absolutePath.endsWith(".png")) {
        format = Bitmap.CompressFormat.PNG
        quality = 100
    }

Kudos for the amazing library, anyway!

@Dhaval2404
Copy link
Owner

@Dinosane2 Good Finding buddy, I will make it 100.
Thank you!

Dhaval2404 added a commit that referenced this issue Jun 30, 2020
Set default compression quality as 100

#93
@Dhaval2404 Dhaval2404 added this to the v2.0 milestone Jun 30, 2020
Dhaval2404 added a commit that referenced this issue Aug 2, 2020
Set default compression quality as 100

#93
@Dhaval2404 Dhaval2404 removed this from the v2.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants