Skip to content

Commit

Permalink
Fix extraEnvVars in helm chart (#582)
Browse files Browse the repository at this point in the history
Fixes #581 

`extraEnvVars` was being treated as a string in some places and a list
in others. This PR makes it a list everywhere, any values files that
look like this should be updated to remove the `|`:

```yaml
extraEnvVars: |
  - name: BEAMLINE
    value: i04
```
  • Loading branch information
callumforrester authored Aug 8, 2024
1 parent 6d0b50f commit 5351741
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions helm/blueapi/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,8 @@ spec:
- "-c"
- "/config/config.yaml"
- "serve"
{{- with .Values.extraEnvVars }}
env:
{{- tpl .Values.extraEnvVars . | nindent 10 }}
{{- end }}
{{- toYaml .Values.extraEnvVars | nindent 12 }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand Down

0 comments on commit 5351741

Please sign in to comment.