Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI tests or exclude CLI directory from code coverage #256

Open
DiamondJoseph opened this issue Jun 1, 2023 · 5 comments
Open

Add CLI tests or exclude CLI directory from code coverage #256

DiamondJoseph opened this issue Jun 1, 2023 · 5 comments
Labels
cli Relates to CLI code rest api Potential REST API changes tests Issues around increasing test coverage/fixing tests

Comments

@DiamondJoseph
Copy link
Contributor

CLI calls to CLI REST client calls to REST API calls into code.
Mocking out the REST API to ensure that the CLI is calling the correct endpoints would be a useful sanity check.
Currently CLI + CLI REST client adds ~3 lines of uncovered "code" for every endpoint which brings down the reported code coverage of functional code.
Is there an easy way to test Click commands in situ?

Or: Move CLI client into its own repository?

@stan-dot
Copy link
Contributor

stan-dot commented Mar 8, 2024

connected to #242

@stan-dot stan-dot added tests Issues around increasing test coverage/fixing tests cli Relates to CLI code rest api Potential REST API changes labels Mar 8, 2024
@stan-dot stan-dot self-assigned this May 1, 2024
@stan-dot
Copy link
Contributor

stan-dot commented May 1, 2024

#364 is very closely connected

@stan-dot
Copy link
Contributor

doing this functionality as part of the autogenerated client part in #441

@stan-dot
Copy link
Contributor

Mocking out the REST API to ensure that the CLI is calling the correct endpoints would be a useful sanity check.
that is effectively done in #441 , we could close this as redundant

@stan-dot
Copy link
Contributor

will do this after migration to pydantic 2 #449 and code auto gen ( #364 )

@stan-dot stan-dot removed their assignment May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relates to CLI code rest api Potential REST API changes tests Issues around increasing test coverage/fixing tests
Projects
None yet
Development

No branches or pull requests

2 participants