remove pydantic pinning

[stan-dot]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (0a634dc) to head (e0a9b79).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files          41       41           
  Lines        1708     1708           
=======================================
  Hits         1540     1540           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DiamondJoseph]

I'm surprised it was as simple as just removing the pinning- the service still starts with our old-style BaseModels in Pydantic v2? Or are we picking up a Pydantic v1 pin from some other (dodal, ophyd-async?) dependency?

[callumforrester]

Yeah, unsure if this is happy because it just works or lack of tests...

[stan-dot]

should a test 'staging' deployment be used for this?

[callumforrester]

@stan-dot I think it's fine if someone has the time to play around with a local dev version of the server.

[stan-dot]

@callumforrester I can try this on a branch with the ViSR project is that ok?

[callumforrester]

@stan-dot I think this configuration will still install pydantic v1 because the pinned fastapi version depends on it, see #454

[stan-dot]

so it's dependent on GDA. rip
#454 (comment)

I'm unassigning myself from this issue as it does not seem resolvable in the nearest future

[DiamondJoseph]

It's also pinned in ScanSpec, dodal and other places. We need to have a mass move over

[stan-dot]

superceded by #564