Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase codecov threshold #362

Closed
callumforrester opened this issue Feb 5, 2024 · 2 comments · Fixed by #483
Closed

Increase codecov threshold #362

callumforrester opened this issue Feb 5, 2024 · 2 comments · Fixed by #483
Assignees
@stan-dot
Labels
github_actions Pull requests that update GitHub Actions code tests Issues around increasing test coverage/fixing tests

Comments

@callumforrester
Copy link
Contributor

We currently require at least 70% code coverage to merge PRs, we can probably push this up since PRs are now scoring in the high 80s. I propose 85% as the new threshold.
@callumforrester callumforrester added github_actions Pull requests that update GitHub Actions code tests Issues around increasing test coverage/fixing tests labels Feb 5, 2024
@stan-dot
Copy link
Contributor

https://github.com/DiamondLightSource/blueapi/actions/runs/8777167878/job/24081731537

this recent passing test was 89%, in agreement with what has been proposed

@callumforrester
Copy link
Contributor Author

Agreed, want to raise a PR?

@stan-dot stan-dot self-assigned this May 22, 2024
stan-dot added a commit that referenced this issue May 22, 2024
@stan-dot
coverage upgrade to 85%
6be9ff2 
fixes #362
@stan-dot stan-dot mentioned this issue May 22, 2024
Merged
stan-dot added a commit that referenced this issue May 22, 2024
@stan-dot
coverage upgrade to 85% (#483)
a476f08 
fixes #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stan-dot stan-dot

Labels
github_actions Pull requests that update GitHub Actions code tests Issues around increasing test coverage/fixing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

coverage upgrade to 85% DiamondLightSource/blueapi
2 participants
@callumforrester @stan-dot