-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make worker asynchronous and stoppable #145
Conversation
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 74.62% 82.95% +8.33%
==========================================
Files 38 39 +1
Lines 1056 1103 +47
==========================================
+ Hits 788 915 +127
+ Misses 268 188 -80
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dfb159f
to
dc1fb89
Compare
@RAYemelyanova I think this this is ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I've got a couple of comments about small things.
4f4617b
to
0c22c87
Compare
Changes:
run_forever
tostop
andstart
start
run worker in its own thread