-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create documentation page about events #152
Conversation
callumforrester
commented
Apr 25, 2023
- Add page about events to developer documentation
- Explain why we need to add new events on top of the event model
- Explain the use of correlation IDs
Still to do: make API reference and point to that |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
- Coverage 83.07% 74.47% -8.61%
==========================================
Files 40 37 -3
Lines 1111 1050 -61
==========================================
- Hits 923 782 -141
- Misses 188 268 +80 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, otherwise LGTM
Presumably going to need an update for emitting state events on same topic? |
58ecb40
to
6256cea
Compare
Do that as part of addressing #176 |