Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #159

Merged
merged 1 commit into from
May 2, 2023
Merged

Remove support for Python 3.8 #159

merged 1 commit into from
May 2, 2023

Conversation

tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented May 2, 2023

Fixes: #122
May also fix #114

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes #114

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #159 (57df25d) into main (58317f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          37       37           
  Lines        1050     1050           
=======================================
  Hits          782      782           
  Misses        268      268           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DiamondJoseph DiamondJoseph merged commit bcfabb7 into DiamondLightSource:main May 2, 2023
@tpoliaw tpoliaw deleted the min_version branch May 2, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8 Update github action matrix to test -e on/off on same python version
2 participants