Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix topic publishing #195

Merged
merged 1 commit into from
May 15, 2023
Merged

fix topic publishing #195

merged 1 commit into from
May 15, 2023

Conversation

rosesyrett
Copy link
Contributor

copied code from before fastAPI change in service/app.py to re-establish the same subscriptions on the worker

@rosesyrett
Copy link
Contributor Author

solves #196

I feel like we need a test case for this. But maybe this is overkill considering active-mq topics are going to change anyways due to #176

joeshannon
joeshannon approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@joeshannon joeshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes it!

@joeshannon joeshannon mentioned this pull request May 15, 2023
Closed
@rosesyrett rosesyrett merged commit 340de26 into DiamondLightSource:main May 15, 2023
@rosesyrett rosesyrett deleted the fix-topics branch May 15, 2023 10:09
@keithralphs keithralphs linked an issue May 15, 2023 that may be closed by this pull request
Topics are not being published correctly #196
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeshannon joeshannon joeshannon approved these changes

@callumforrester callumforrester Awaiting requested review from callumforrester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topics are not being published correctly
2 participants
@rosesyrett @joeshannon